Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase out the use of WSREP_KEY_SHARED type of keys #227

Open
ayurchen opened this issue Apr 6, 2024 · 0 comments
Open

Phase out the use of WSREP_KEY_SHARED type of keys #227

ayurchen opened this issue Apr 6, 2024 · 0 comments
Assignees
@ayurchen

Comments

@ayurchen
Copy link
Member

ayurchen commented Apr 6, 2024 •
edited
Loading

SHARED keys have poor semantics and REFERENCE keys should be used instead. SHARED keys must be only recognized for backward compatibility.
@ayurchen ayurchen self-assigned this Apr 6, 2024
ayurchen added a commit that referenced this issue Apr 6, 2024
@ayurchen
Phase out the use of WSREP_KEY_SHARED key type in favour of WSREP_KEY…
ce6b433 
…_REfERENCE

(but keep support for it for backward compatibility)
The only place where wsrep-lib made use of WSREP_KEY_SHARED is
wsrep::append_sr_keys_for_commit() which is used only with protocols >= 4
so we don't need to worry about the protocol version and just change
wsrep::key::shared to wsrep::key::reference.

Refs #227
@ayurchen ayurchen mentioned this issue Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayurchen ayurchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ayurchen