Fixes codership/mysql-wsrep#149 #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o move FLUSH TABLES.
With this commit,
a) FLUSH * LOGS have been added to TOI as well.
The commands being:
FLUSH ERROR LOGS;
FLUSH SLOW LOGS;
FLUSH GENERAL LOGS;
FLUSH ENGINE LOGS;
FLUSH RELAY LOGS;
b) FLUSH LOGS and FLUSH BINARY LOGS are not replicated. Former is not
done because it enables BINARY LOGS too.
Tests have been added for them.
In addition, another test has been added which runs the same through
binlogging and gtid enabled.
Finally, REFRESH_TABLES logic from previous commit has been moved to
reload_acl_and_cache to just before close_cached_tables.
This is required because:
a) TOI for REFRESH_TABLES needs to be done before the command to be
executed, in this case in close_cached_tables.
b) Also, since LOCK TABLE WRITE is not replicated, it needs to be
done after the check of thd->locked_tables_mode as described in
earlier commit.
Also, a comment about 'thread holds MDL locks at TI' appearing in
the logs has been added to indicate that it is benign for this
context.
Conflicts:
sql/sql_reload.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.