Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Amend version identifier in ID #24

Merged
merged 2 commits into from
Sep 22, 2023
Merged

BREAKING CHANGE: Amend version identifier in ID #24

merged 2 commits into from
Sep 22, 2023

Conversation

podedra92
Copy link
Contributor

Amend the version identifier from publisher.extension-version to publisher.extension@1.0.0.
In an effort to address #23

Note: This is a breaking change as it amends the extension ID and so will change the way extensions are removed from Code Marketplace

@github-actions
Copy link

github-actions bot commented Jul 28, 2023 •
edited
Loading

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ @code-asher
❌ @prakash Odedra
Prakash Odedra seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@podedra92 podedra92 marked this pull request as draft July 28, 2023 11:45
@podedra92
Copy link
Contributor Author

recheck

@podedra92
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@podedra92 podedra92 changed the title Breaking: Amend version identifier in ID BREAKING CHANGE: Amend version identifier in ID Jul 28, 2023
@code-asher
Use - in summary
0ec12ef 
This is used in a list displayed in the CLI after you remove, like:

Removed vscodevim.vim
  - 1.0.1
  - 2.0.1

So a dash feels more appropriate to me.
@code-asher code-asher marked this pull request as ready for review September 22, 2023 22:02
code-asher
code-asher approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@code-asher code-asher merged commit 37778ad into coder:main Sep 22, 2023
4 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@podedra92 @code-asher