Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect capture groups during removal #23

Closed
podedra92 opened this issue Jul 24, 2023 · 1 comment
Closed

Incorrect capture groups during removal #23

podedra92 opened this issue Jul 24, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@podedra92
Copy link
Contributor

Description

Some packages do not adhere to the expected convention during remove.
We are expected to pass publisher.extension-1.0.0 or publisher.extension ParseExtensionID uses regex capture groups to split this string or "id"

May be better placed just to pass in Publisher/extension/version (optional) as seperate args.
Or introduce a breaking change like using a different char maybe + to replace - for version identifier

Example Extensions

@code-asher
Copy link
Member

code-asher commented Jul 24, 2023

Thank you for the report!

I think maybe we change this to @, the - was initially done to match VS Code but I think there was a misunderstanding as VS Code actually uses @ (or maybe they ran into the same bug and changed it).

@code-asher code-asher added the bug Something isn't working label Aug 15, 2023
@code-asher code-asher self-assigned this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants