This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Timezone Setup #10
Open
Timezone Setup #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is needed for frontend time calculations better to do it once the app is initialized
save the offset to UTC to be used by the app much faster and more reliable doing it on the server
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds
GA_TIMEZONE_OFFSETto the ENV.This allows the dashboard to better calculate the displayed barchart with accurate results from GA.
It's much easier to perform this step in the setup since we already asking GA for all the information. And the timezone is already available.
Anybody that is not using the setup can set the env variable themselves.