True Tokenless for BA and TA #882

nora-codecov · 2024-10-10T23:23:14Z

Purpose/Motivation

TT requires certain identifiers, BA and TA don't have the identifiers in their path, so I make custom methods to get the identifiers so that BA and TA can use TT.

Links to relevant tickets

codecov/engineering-team#2298

codecov-notifications · 2024-10-10T23:35:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codecov · 2024-10-10T23:35:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (8945e37) to head (e5a7000).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   96.31%   96.32%           
=======================================
  Files         823      823           
  Lines       19079    19104   +25     
=======================================
+ Hits        18376    18401   +25     
  Misses        703      703

Flag	Coverage Δ
unit	`92.67% <100.00%> (+0.01%)`	⬆️
unit-latest-uploader	`92.67% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joseph-sentry

left a couple of comments on the test results stuff that may also apply to BA

codecov_auth/authentication/repo_auth.py

upload/views/helpers.py

codecov-public-qa · 2024-10-12T01:19:19Z

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2749 tests with 1 failed, 2742 passed and 6 skipped.

View the full list of failed tests

pytest

Class name: api.internal.tests.test_charts.TestChartQueryRunnerQuery
Test name: test_query_aggregates_multiple_repository_totals

self = <tests.test_charts.TestChartQueryRunnerQuery testMethod=test_query_aggregates_multiple_repository_totals>

    @override_settings(GITHUB_CLIENT_ID="3d44be0e772666136a13")
    def test_query_aggregates_multiple_repository_totals(self):
        query_runner = ChartQueryRunner(
            user=self.user,
            request_params={
                "owner_username": self.org.username,
                "service": self.org.service,
                "end_date": str(timezone.now()),
                "grouping_unit": "day",
            },
        )
    
        results = query_runner.run_query()
    
        assert len(results) == 1
>       assert results[0]["total_hits"] == 114
E       AssertionError: assert Decimal('14') == 114

.../internal/tests/test_charts.py:564: AssertionError

codecov-qa · 2024-10-12T01:22:16Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
2743	1	2742	6

View the top 1 failed tests by shortest run time

api.internal.tests.test_charts.TestChartQueryRunnerQuery test_query_aggregates_multiple_repository_totals

Stack Traces | 0.072s run time

self = &lt;tests.test_charts.TestChartQueryRunnerQuery testMethod=test_query_aggregates_multiple_repository_totals&gt;

    @override_settings(GITHUB_CLIENT_ID="3d44be0e772666136a13")
    def test_query_aggregates_multiple_repository_totals(self):
        query_runner = ChartQueryRunner(
            user=self.user,
            request_params={
                "owner_username": self.org.username,
                "service": self.org.service,
                "end_date": str(timezone.now()),
                "grouping_unit": "day",
            },
        )
    
        results = query_runner.run_query()
    
        assert len(results) == 1
&gt;       assert results[0]["total_hits"] == 114
E       AssertionError: assert Decimal('14') == 114

.../internal/tests/test_charts.py:564: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

JerrySentry · 2024-10-14T16:44:05Z

codecov_auth/authentication/repo_auth.py

+ """
+ BA sends this in as git_service, TA sends this in as service.
+ Use this function so this Check class can be used by both views.
+ """


Could probably be return validated_data.get("git_service") or validated_data.get("service")

JerrySentry · 2024-10-14T16:45:32Z

upload/views/test_results.py

@@ -39,13 +39,13 @@ def has_permission(self, request, view):
 class UploadSerializer(serializers.Serializer):
 commit = serializers.CharField(required=True)
 slug = serializers.CharField(required=True)
+ service = serializers.CharField(required=False) # git_service


How come TA can't use git_service?

Since it's already live in prod I figured it would be a whole thing to switch over to a different var name - what do you think @joseph-sentry ?

JerrySentry · 2024-10-14T16:45:52Z

upload/views/helpers.py

@@ -1,8 +1,13 @@
+import logging


This file can now be deleted right?

I can delete get_repository_and_owner_from_slug_and_commit, my bad I thought I had removed it! ty for catching.

nora-codecov requested a review from a team October 10, 2024 23:23

joseph-sentry reviewed Oct 11, 2024

View reviewed changes

codecov_auth/authentication/repo_auth.py Outdated Show resolved Hide resolved

upload/views/helpers.py Outdated Show resolved Hide resolved

JerrySentry reviewed Oct 11, 2024

View reviewed changes

upload/views/helpers.py Outdated Show resolved Hide resolved

JerrySentry reviewed Oct 11, 2024

View reviewed changes

upload/views/helpers.py Outdated Show resolved Hide resolved

nora-codecov force-pushed the nora/2298 branch from f2f587d to 609eaf8 Compare October 12, 2024 01:07

JerrySentry reviewed Oct 14, 2024

View reviewed changes

nora-codecov added 3 commits October 15, 2024 13:16

True Tokenless for BA and TA

3cb0f9d

redo the whole thing, condense into one class that both views share

f9d8307

remove this chunk

e5a7000

nora-codecov force-pushed the nora/2298 branch from 609eaf8 to e5a7000 Compare October 15, 2024 20:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

True Tokenless for BA and TA #882

True Tokenless for BA and TA #882

nora-codecov commented Oct 10, 2024

codecov-notifications bot commented Oct 10, 2024 •

edited

Loading

codecov bot commented Oct 10, 2024 •

edited

Loading

joseph-sentry left a comment

codecov-public-qa bot commented Oct 12, 2024

pytest

codecov-qa bot commented Oct 12, 2024

JerrySentry Oct 14, 2024

JerrySentry Oct 14, 2024

nora-codecov Oct 15, 2024

JerrySentry Oct 14, 2024

nora-codecov Oct 15, 2024

True Tokenless for BA and TA #882

Are you sure you want to change the base?

True Tokenless for BA and TA #882

Conversation

nora-codecov commented Oct 10, 2024

Purpose/Motivation

Links to relevant tickets

codecov-notifications bot commented Oct 10, 2024 • edited Loading

Codecov Report

codecov bot commented Oct 10, 2024 • edited Loading

Codecov Report

joseph-sentry left a comment

Choose a reason for hiding this comment

codecov-public-qa bot commented Oct 12, 2024

❌ Failed Test Results:

pytest

codecov-qa bot commented Oct 12, 2024

❌ 1 Tests Failed:

JerrySentry Oct 14, 2024

Choose a reason for hiding this comment

JerrySentry Oct 14, 2024

Choose a reason for hiding this comment

nora-codecov Oct 15, 2024

Choose a reason for hiding this comment

JerrySentry Oct 14, 2024

Choose a reason for hiding this comment

nora-codecov Oct 15, 2024

Choose a reason for hiding this comment

codecov-notifications bot commented Oct 10, 2024 •

edited

Loading

codecov bot commented Oct 10, 2024 •

edited

Loading