Minor code refactor

code-pushup · Apr 9, 2024 · d2c12da · d2c12da
1 parent c6a58e4
commit d2c12da
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/__tests__/main.test.ts b/__tests__/main.test.ts
@@ -222,9 +222,9 @@ describe('code-pushup action', () => {
 
  expect(core.setFailed).not.toHaveBeenCalled()
 
- expect(core.error).toHaveBeenCalledTimes(0)
- expect(core.warning).toHaveBeenCalledTimes(0)
- expect(core.notice).toHaveBeenCalledTimes(0)
+ expect(core.error).not.toHaveBeenCalled()
+ expect(core.warning).not.toHaveBeenCalled()
+ expect(core.notice).not.toHaveBeenCalled()
 
  expect(core.setOutput).toHaveBeenCalledWith('comment-id', 10)
 

diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/issues.ts b/src/issues.ts
@@ -97,7 +97,7 @@ function positionsMatch(
  return hasPosition(prev) === hasPosition(curr)
  }
  return (
- startLinesMatch(prev, curr, changedFiles) ||
+ adjustedStartLinesMatch(prev, curr, changedFiles) ||
  adjustedLineSpansMatch(prev, curr, changedFiles)
  )
 }
@@ -108,7 +108,7 @@ function hasPosition(
  return source.position != null
 }
 
-function startLinesMatch(
+function adjustedStartLinesMatch(
  prev: Required<SourceFileIssue['source']>,
  curr: Required<SourceFileIssue['source']>,
  changedFiles: ChangedFiles