Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use nx-verdaccio for cli-e2e #844

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Oct 15, 2024

Precondition:

This PR uses nx-verdaccio for the cli-e2e project only. In the precondition PR #842 the e2e target gets refactored and the tooling code gets a cleanup

@github-actions github-actions bot added 🔬 testing writing tests 🦾 CI/CD continuous integration and deployment 🛠️ tooling labels Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 63fc1f1 with source commit 13a63a4.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🔴 45 ↓ −9.1
Updates 🟡 75 🟡 75 ↑ +0.1
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 82 🟡 82
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 4 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🔴 45 ↓ −9.1
JS Packages NPM outdated dependencies 🟡 75 🟡 75 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 610 ms 🟩 Root document took 420 ms ↓ −31.2 %
Lighthouse Speed Index 🟨 5.5 s 🟥 7.4 s ↑ +34.4 %
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟨 3.9 s ↑ +26.3 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.2 s ↑ +3.6 %
Lighthouse First Meaningful Paint 🟨 3.1 s 🟨 3.2 s ↑ +3.6 %
JS Packages Outdated NPM dev dependencies. 🟨 57 outdated package versions (33 major, 15 minor, 1 preminor, 7 patch, 1 prerelease) 🟨 58 outdated package versions (33 major, 15 minor, 1 preminor, 7 patch, 2 prerelease) ↑ +1.8 %
Lighthouse Minimizes main-thread work 🟥 19.1 s 🟥 22.3 s ↑ +16.7 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,170 ms 🟥 Potential savings of 170 ms ↓ −85.7 %
Lighthouse JavaScript execution time 🟥 9.9 s 🟥 10.8 s ↑ +8.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −2.8 %
Lighthouse Time to Interactive 🟥 17.6 s 🟥 17.1 s ↓ −2.8 %
Lighthouse Max Potential First Input Delay 🟥 3,230 ms 🟥 3,660 ms ↑ +13.5 %
Lighthouse Total Blocking Time 🟥 7,370 ms 🟥 7,670 ms ↑ +4.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 70 KiB 🟥 Potential savings of 70 KiB ↑ +93.8 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,812 KiB 🟩 Total size was 1,812 KiB ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 130 ms 🟩 200 ms ↑ +57.2 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 100 ms ↑ +39.8 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %

495 other audits are unchanged.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Oct 19, 2024

Code PushUp

🥳 Code PushUp report has improved – compared target commit 46d2b52 with source commit 3465e16.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 55 🟡 57 ↑ +2
Updates 🟡 76 🟡 76 ↑ +0.1
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 82 🟡 82
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 2 groups improved, 👍 5 audits improved, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 55 🟡 57 ↑ +2
JS Packages NPM outdated dependencies 🟡 76 🟡 76 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 900 ms 🟩 Root document took 350 ms ↓ −61.3 %
Lighthouse Speed Index 🟥 6.4 s 🟨 5.8 s ↓ −9.9 %
Lighthouse Largest Contentful Paint 🟨 3.0 s 🟨 2.8 s ↓ −5.7 %
Lighthouse Time to Interactive 🟥 17.2 s 🟥 16.7 s ↓ −3.2 %
JS Packages Outdated NPM dev dependencies. 🟨 49 outdated package versions (27 major, 16 minor, 1 preminor, 4 patch, 1 prerelease) 🟨 49 outdated package versions (27 major, 16 minor, 1 preminor, 4 patch, 1 prerelease)  +0 %
Lighthouse Total Blocking Time 🟥 7,930 ms 🟥 9,420 ms ↑ +18.7 %
Lighthouse Minimizes main-thread work 🟥 20.8 s 🟥 21.9 s ↑ +5.2 %
Lighthouse JavaScript execution time 🟥 10.6 s 🟥 11.4 s ↑ +7.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −3.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Max Potential First Input Delay 🟥 3,060 ms 🟥 3,210 ms ↑ +5 %
Lighthouse Server Backend Latencies 🟩 220 ms 🟩 90 ms ↓ −61.7 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 630 ms 🟥 Potential savings of 730 ms ↑ +15.2 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟨 2.6 s ↓ −0.5 %
Lighthouse First Meaningful Paint 🟨 2.7 s 🟨 2.6 s ↓ −0.5 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 10 ms ↓ −15.1 %
JS Packages Outdated NPM prod dependencies. 🟨 15 outdated package versions (5 major, 5 minor, 5 patch) 🟨 13 outdated package versions (5 major, 4 minor, 4 patch) ↓ −13.3 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,807 KiB 🟩 Total size was 1,807 KiB ↓ −0.1 %
Lighthouse Avoids an excessive DOM size 🟥 2,235 elements 🟥 2,234 elements ↓ −0.1 %

494 other audits are unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦾 CI/CD continuous integration and deployment 🔬 testing writing tests 🛠️ tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants