Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sqllogictest): add test utils regarding bpm & disk #764

Merged
merged 1 commit into from
Oct 21, 2024
Merged

test(sqllogictest): add test utils regarding bpm & disk #764

merged 1 commit into from
Oct 21, 2024

Conversation

xx01cyx
Copy link
Member

@xx01cyx xx01cyx commented Oct 21, 2024 •
edited
Loading

This PR introduces necessary test utils for checking students' external merge sort implementations, including:

  1. Maximum number of pages written to disk
  2. Minimum number of pages written to disk
  3. Minimum number of pages deleted on disk

prashanthduvvada
prashanthduvvada approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@prashanthduvvada prashanthduvvada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@xx01cyx xx01cyx merged commit 719e735 into master Oct 21, 2024
4 checks passed
@xx01cyx xx01cyx deleted the yx/disk-mgr-num-delete branch October 21, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanthduvvada prashanthduvvada prashanthduvvada approved these changes

@connortsui20 connortsui20 Awaiting requested review from connortsui20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xx01cyx @prashanthduvvada