Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to rich because colorama is not that great #54

Merged
merged 12 commits into from
Jan 9, 2024
Merged

Conversation

jpfleischer
Copy link
Member

@jpfleischer jpfleischer commented Jan 8, 2024

switch from colorama to rich as rich is supported in windows

  • cloudmesh-installer switch to rich
  • merge conflict fixed
  • version number may still be wrong
  • make sure pytest in cloudmesh-common succeeds for mac
  • make sure pytest in cloudmesh-common succeeds for linux
  • make sure pytest in cloudmesh-common succeeds for windows
  • fix def text(color="RED", prefix=None, message=None):

@laszewsk
Copy link
Member

laszewsk commented Jan 8, 2024

please can you look at conflict

@laszewsk
Copy link
Member

laszewsk commented Jan 8, 2024

other dependencies based on packages that may have wrong requirements and toml

  • cloudmesh-gpu
  • cloudmesh-installer -- needs to be changed at the same time as common
  • cloudmesh-vpn
  • cloudmesh-inventory
  • [will not do] cloudmesh-admin (not yet transitioned to new namespace and pyprojec.toml)
    admin is largely installing mongodb from commandlne
    since then mongo has changed a lot and is no longer as liberal with licenses.
    for that reason we have laregly disbandedn teh use of mongo and use yamldb
    hence if someone relay wants to use it at that time we can change.
    admnin contains some tricks that were undocumented on how to install mongo from commandline.
    I am not sure if they still work. We should probably move admin to deprecated.

as they all use cloudmesh-common we want to remove all dependencies already covered by cloudmesh common this way we do not end up with overlapping requirements.

Copy link
Member

@laszewsk laszewsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other then cloudmesh-install dependency this seems ok.
However checks fail

@laszewsk laszewsk merged commit 6c526fb into main Jan 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants