New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated terraform module and fixed depriciation variables #54

Open

vedant990 wants to merge 5 commits into master from fix/pipeline

vedant990 commented Sep 18, 2024

What :

Updated the Azurerm version from 3.112 to 4.0.0
Added Provider Configuration version.tf
Fixed attributes like retention policy trust policy and encryption
Removed skip_provider block as it is depreciated

Why :

Dynamic Blocks has been removed in 4.0.0 version
Provider alias was not recognized by Terraform


          fix: updated terraform module and fixed depriciation variables

vedant990 added the enhancement label

vedant990 requested review from 13archit and d4kverma

September 18, 2024 18:28

clouddrove-ci self-assigned this


          fix: version.tf and improved format

46f19db

13archit reviewed

View reviewed changes

main.tf Outdated Show resolved Hide resolved

13archit reviewed

View reviewed changes

main.tf Show resolved Hide resolved

13archit reviewed

View reviewed changes

examples/basic/example.tf Outdated Show resolved Hide resolved

13archit reviewed

View reviewed changes

examples/basic/example.tf Outdated Show resolved Hide resolved

13archit reviewed

View reviewed changes

examples/complete/example.tf Outdated Show resolved Hide resolved

13archit reviewed

View reviewed changes

examples/complete/example.tf Outdated Show resolved Hide resolved

13archit reviewed

View reviewed changes

examples/with_existing_dns_zone_in_diff_subs/example.tf Outdated Show resolved Hide resolved

13archit reviewed

View reviewed changes

examples/with_existing_dns_zone_in_diff_rg/example.tf Outdated Show resolved Hide resolved


          fix: subscription id and removed commented code

622f6a0

vedant990 requested a review from 13archit

September 24, 2024 13:40

13archit reviewed

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved


          fix: Updated codeowners

982a837

Member

clouddrove-ci commented Oct 4, 2024

`Terraform Security Scan` Failed

Show Output


          fix : Renamed rentention_policy variable to rentention_policy_in_days

b77e465

Member

clouddrove-ci commented Oct 9, 2024

`Terraform Security Scan` Failed

Show Output

vedant990 requested a review from 13archit

October 14, 2024 21:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels