Unify focus and list items rendering in dropdown menus #16642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (ui): Unify dropdown menus focus behavior with menu bar and other menus.
Internal (ui): Use
ListItemButtonView
instead ofButtonView
class as base for dropdown menu buttons.Internal (ui): Add support for
hasIconSpace
attribute ofListItemButtonView
and allocate space for check marks if there is at least one toggleable menu item in menu.Additional information
3.1. We don't have manual tests for dropdown menu, and the only way to test that is AI.
3.2. The presence of search input is important to show how "hover focus" behaves with that kind of dropdown.
Part of PRs:
Screens
Before:
After:
dropdown-focus-keyboard-unify-2024-07-01_13.59.37.mp4