Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned to ckeditor5-dev ESM changes #313

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Aligned to ckeditor5-dev ESM changes #313

merged 6 commits into from
Oct 3, 2024

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Sep 19, 2024

Suggested merge commit message (convention)

Internal: Aligned to ckeditor5-dev ESM changes.


Additional information

This PR requires ckeditor/ckeditor5-dev#1011 to be released. When it is released, all ckeditor5-dev-* packages need to be bumped in this repository.

@coveralls
Copy link

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 09d8522e-476e-47a3-83fb-585172bf9cc1

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 72bfe7fc-9e78-4aec-9127-e74f6d90dd2d: 0.0%
Covered Lines: 79
Relevant Lines: 79

💛 - Coveralls

@psmyrek psmyrek marked this pull request as draft September 19, 2024 09:38
package.json Show resolved Hide resolved
@psmyrek psmyrek marked this pull request as ready for review October 2, 2024 12:14
pomek
pomek previously approved these changes Oct 2, 2024
pomek
pomek previously approved these changes Oct 2, 2024
@pomek
Copy link
Member

pomek commented Oct 2, 2024

@filipsobol, could you help us?

image

@filipsobol
Copy link
Member

Fixed it by taking the yarn.lock from master and running yarn install. For whatever reason, removing yarn.lock and running yarn install causes this issue. I will figure out what's causing this issue.

@filipsobol
Copy link
Member

That's likely a bug in a newer version of vue-tscvuejs/language-tools#4822

@pomek
Copy link
Member

pomek commented Oct 2, 2024

Thank you!

@pomek pomek merged commit 2c5e74a into master Oct 3, 2024
6 checks passed
@pomek pomek deleted the ci/3772 branch October 3, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants