Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Profile Page - "Editable" view AND "true read only" view #2789

Closed
7 tasks done
therealslimhsiehdy opened this issue Sep 19, 2024 · 0 comments · Fixed by #2920
Closed
7 tasks done

Manage Profile Page - "Editable" view AND "true read only" view #2789

therealslimhsiehdy opened this issue Sep 19, 2024 · 0 comments · Fixed by #2920

Comments

@therealslimhsiehdy
Copy link
Contributor

therealslimhsiehdy commented Sep 19, 2024

Issue description

Right now we have a Member page, but it doesn't allow you to edit or view more information on those members. Our goal is to fix that. With this ticket, we want to be able to go from the Member table and see a view that displays individual specific Member Information. Because we have some admins that will have View Only access and some that will have Member Management Access, we want to make sure that we support both a read only view and an editable view. There is a lot of functionality that we want on this page, so we're starting with the main pieces of displaying text and layout changes with some functionality reserved for later tickets.

Acceptance criteria

  • Here is the Figma link for read only
  • Here is the Figma link for editable view
  • Clicking "gear icon Manage" on the Member Page will open to the Member Profile view
  • Add the new Editable AND Read-Only Views for Member Profile with the exception of the buttons. The buttons DO NOT need to be operational but should be present (the 3 dots, edit, manage - and the buttons are hidden in view only mode as well)
  • If user has View Only access, then the Ready Only View shows. Vice versa, if the user has Member Management access, then the Manage/Editable View shows and they should have the ability to edit things
  • Supports display for INVITED users and EXISTING users
  • Follow the Figma's annotations 1 - 10 with the exception of # 3 (vertical 3 dots/dropdown menu/ellipses vertical icon/kebab) as that is covered in a different ticket already Org Member Page - Three dots/ellipsis Buttons #2764
  • In PortfolioInvitation rename portfolio_additional_permissions and portfolio_roles to be additional_permissions and roles respectively. (This should now match UserPortfolioPermissions)
  • Where possible, any html or other files that is checking roles or additional_permissions in both PortfolioInvitation & UserPortfolioPermission should be refactored to remove an redundancy.

Additional context

Screenshot 2024-09-18 at 5 02 34 PM

Note: The edit view shows the example of a Existing User, and the Read Only View shows an example of a Invited User

Links to other issues

@therealslimhsiehdy therealslimhsiehdy changed the title (DRAFT) Manage Member Page - "Editable" view AND "true read only" view Manage Member Page - "Editable" view AND "true read only" view Sep 25, 2024
@therealslimhsiehdy therealslimhsiehdy changed the title Manage Member Page - "Editable" view AND "true read only" view Manage Profile Page - "Editable" view AND "true read only" view Sep 25, 2024
dave-kennedy-ecs added a commit that referenced this issue Oct 16, 2024
#2789: Portfolio member/invited member page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment