Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fields PortfolioInvitation and refactor related sections #2900

Closed
2 tasks
abroddrick opened this issue Oct 4, 2024 · 0 comments
Closed
2 tasks

Rename fields PortfolioInvitation and refactor related sections #2900

abroddrick opened this issue Oct 4, 2024 · 0 comments
Assignees
Labels
dev pulled in pulled into a sprint after sprint planning refactor

Comments

@abroddrick
Copy link
Contributor

Issue description

Right now, PortfolioInvitations and UserPortfolioPermissions have two fields that are defined identically, except for their names are slightly different. Not only is this inconsistent and implies they are different from each other more than they really are, it also means we have to have a lot of dupli

Acceptance criteria

  • In PortfolioInvitation rename portfolio_additional_permissions and portfolio_roles to be additional_permissions and roles respectively. (This should now match UserPortfolioPermissions)
  • Where possible, any html or other files that is checking roles or additional_permissions in both PortfolioInvitation & UserPortfolioPermission should be refactored to remove an redundancy.

Additional context

The two models, note that we want to change PortfolioInvitation to match UserPortfolioPermissions
image

Links to other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev pulled in pulled into a sprint after sprint planning refactor
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants