Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the docker-pre-commit hook #489

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Enable the docker-pre-commit hook #489

merged 1 commit into from
Jul 22, 2022

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request simply enables the docker-pre-commit hook in our pre-commit configuration.

💭 Motivation and context

This is a progress item for #301 and since we do not house any Docker configurations in this repository involves no other work.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jul 21, 2022
@mcdonnnj mcdonnnj self-assigned this Jul 21, 2022
jsf9k
jsf9k approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such change!

dav3r
dav3r approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@mcdonnnj mcdonnnj merged commit b85eccb into develop Jul 22, 2022
@mcdonnnj mcdonnnj deleted the improvement/enable_docker_pre-commit_hook branch July 22, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r