Drop support for the linux/arm/v6, linux/ppc64le, and linux/s390x platforms
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
bug
jsf9k
approved these changes
Aug 30, 2024
This includes updating all of the system packages installed to the versions available for Alpine Linux 3.20.
This updates the `build-stage` to match the versions of Python and Alpine Linux used in the `compile-stage`. This also includes updating the versions of all system packages installed.
Bump the Python packages installed in the `compile-stage` as follows: - pip from 23.1.2 to 24.2 - pipenv from 2023.10.20 to 2024.1.0 - setuptools from 67.7.2 to 75.1.0 - wheel from 0.40.0 to 0.44.0
Update the version of Python declared in the Pipfile and update the dependencies installed in the Python virtual environment by running `pipenv lock` in the `src/` directory.
Alpine Linux 3.20 configures Python 3 as externally managed, so we need to pass this flag to `pip` to install a Python package directly. Since we are using this to build a Python virtual environment in the `compile-stage` that is moved to the `build-stage` for use in the final image this should pose no issues.
We need some changes that were added in the LLNL/scraper repo but do not yet have a PyPI release. Rather than continue to use a fork in our GitHub organization it makes sense to pull in LLNL/scraper at a specific commit until a new version is release to PyPI.
In the move from Alpine Linux 3.17 to 3.18 we also moved from Cargo 1.64.0 to 1.71.1. This takes us past 1.68, which introduced sparse registries, and 1.70, which made `sparse` the default protocol to use with crates.io (the default registry). This resolves #38, and based on testing it also resolves #32.
mcdonnnj
force-pushed
the
improvement/drop_support_for_some_platforms
branch
from
846fd7b
to
49176b7
Compare
|
|
Drop support for the `linux/arm/v6`, `linux/ppc64le`, and `linux/s390x` platforms. This is done because the Docker image build time with these platforms included pushes the total workflow runtime over the GitHub Actions runtime limit of six hours. This is largely due to these platforms being older, esoteric, and emulated and then having to compile when building certain Python packages.
mcdonnnj
force-pushed
the
improvement/drop_support_for_some_platforms
branch
from
49176b7
to
8fcc09e
Compare
mcdonnnj
changed the title
linux/ppc64le and linux/s390x platformslinux/arm/v6, linux/ppc64le, and linux/s390x platforms
jsf9k
approved these changes
Oct 8, 2024
dav3r
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request drops support for the
linux/arm/v6,linux/ppc64le, andlinux/s390xplatforms when building a Docker image to push to Docker Hub.Note
This pull request is built on top of #147.
💭 Motivation and context
The current full image build is butting up against the six hour runtime limit for GitHub Actions runners. This is due to these platforms needing to build some Python wheels which requires compiling Rust code in conjunction with the fact that all images are being built on a single runner relying on QEMU for all platforms that aren't AMD64. We would like to restore support for these platforms when it becomes viable and that is being tracked in #150.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.