Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with api-keys and logger #658

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Conversation

jayjaybunce
Copy link
Collaborator

@jayjaybunce jayjaybunce commented Sep 30, 2024

🗣 Description

  • Reworked a logger to allow api-keys in requests and only instantiate on requests we setup to log

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

backend/src/tools/logger.ts Fixed Show resolved Hide resolved
@jayjaybunce jayjaybunce marked this pull request as ready for review September 30, 2024 18:36
@jayjaybunce jayjaybunce changed the title [DNM] - Fix backend deployment due to token null in Logger Fix backend deployment due to token null in Logger Sep 30, 2024
@jayjaybunce jayjaybunce changed the title Fix backend deployment due to token null in Logger Resolve issue with api-keys and logger Sep 30, 2024
Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me after walking through the updates with Janson.
It resulted in logs that could be filtered to show the payload with who was invited and by whom.
image

backend/src/tools/logger.ts Fixed Show fixed Hide fixed
Janson Bunce added 2 commits October 2, 2024 09:48
backend/src/tools/logger.ts Fixed Show fixed Hide fixed
@schmelz21 schmelz21 merged commit 1c5e30a into develop Oct 2, 2024
15 of 18 checks passed
@schmelz21 schmelz21 deleted the implement-logging branch October 2, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants