Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint issues related to executables/shell files. #46

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Mar 13, 2024

🗣 Description

Apply fixes made by shfmt and shell-lint.
Fix issues flagged by check-executables-have-shebangs.

  • Add #!/bin/bash to beginning of *.sh files
  • Remove execute permissions from *.js and *.ts files

Fix additional issues flagged by shfmt and shell-lint to include:

  • All changes to backend/tools/deploy-worker.sh
  • Changes to line 34 of backend/worker/pe-worker-entry.sh

💭 Motivation and context

Closes issue #29

🧪 Testing

All existing tests pass.
The following pre-commit hooks now pass.
pre-commit run shfmt --all-files
pre-commit run shell-lint --all-files
pre-commit run check-executables-have-shebangs --all-files

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matthew-Grayson Matthew-Grayson self-assigned this Mar 14, 2024
Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@schmelz21 schmelz21 merged commit fe796f8 into develop Mar 14, 2024
21 of 25 checks passed
@Matthew-Grayson Matthew-Grayson deleted the 29-resolve-executable-file-lint-issues branch March 14, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve Executable File Lint issues
3 participants