-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ReadySetCyber branch for login testing #149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alpahbetized table names.
…display RSC routes in Layout.
…een user and assessment; update question and resource column names.
…een assessment and question; refactor rsc table names.
…Dashboard. Added route for detailed view. Built dummy data. Added home link to header.
…d Detail and Question component UI.
Implemented Login page and logic to redirect unauthorized users
Created new RSC Register Form component. Created new RSC Register Form Style component. Reverted Register Form component. Updated App.tsx to include new RSC components and routes. Updated app.ts to include new register route. Updated users.ts with amended RSC Register end point.
- backend/src/api/users.ts - frontend/src/components/ReadySetCyber/RSCRegisterForm.tsx
- backend/src/api/users.ts - frontend/src/components/ReadySetCyber/RSCRegisterForm.tsx
backend/test/assessments.test.ts
package-lock.json files. Updated shfmt.
hawkishpolicy
requested review from
aloftus23,
cduhn17,
Matthew-Grayson,
nickviola,
rapidray12 and
schmelz21
as code owners
April 4, 2024 17:29
3 tasks
nickviola
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rapidray12
approved these changes
Apr 9, 2024
cisagovbot
pushed a commit
that referenced
this pull request
Apr 30, 2024
…max/ghaction-github-status-4 Bump crazy-max/ghaction-github-status from 3 to 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
💭 Motivation and context
This changes aims to integrate ReadySetCyber users with the Crossfeed platform with limited permissions.
🧪 Testing
📷 Screenshots (if appropriate)
✅ Pre-approval checklist
in code comments.
✅ Pre-merge checklist
✅ Post-merge checklist