Allow http handlers to mark their span as golden [FND-44] #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmux
force-pushed
the
dm/golden-routes
branch
from
383cefc
to
b55731a
Compare
The variadic options stle API is a bit verbose, but avoids a break to the API and is generally only going to be used in library code, so should have minimal impact on day to day use of spans.
danmux
force-pushed
the
dm/otel-span-kind
branch
from
5e1f865
to
8c2be03
Compare
The variadic options stle API is a bit verbose, but avoids a break to the API and is generally only going to be used in library code, so should have minimal impact on day to day use of spans.
danmux
force-pushed
the
dm/golden-routes
branch
2 times, most recently
from
074c747
to
35da0ed
Compare
danmux
force-pushed
the
dm/golden-routes
branch
from
35da0ed
to
ae006b0
Compare
danmux
force-pushed
the
dm/otel-span-kind
branch
from
8c2be03
to
6968132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to retroactively replicate a span as a golden span.
This is needed in things like the gin middleware where the span is automatically created in the middleware - but we only want selected routes to be golden.