Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements for L2 pcap filters #258

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Minor improvements for L2 pcap filters #258

merged 2 commits into from
Sep 28, 2023

Conversation

jschwinger233
Copy link
Member

@jschwinger233 jschwinger233 commented Sep 27, 2023

Fixes: #255

@jschwinger233 jschwinger233 force-pushed the pr/gray/arp-test branch 3 times, most recently from af8a204 to 280c325 Compare September 27, 2023 15:07
@jschwinger233 jschwinger233 marked this pull request as ready for review September 27, 2023 15:17
@jschwinger233 jschwinger233 marked this pull request as draft September 27, 2023 16:10
@jschwinger233 jschwinger233 changed the title Add CI test for ARP Minor improvements for L2 pcap filters Sep 27, 2023
@jschwinger233 jschwinger233 marked this pull request as ready for review September 27, 2023 16:41
@jschwinger233 jschwinger233 marked this pull request as draft September 27, 2023 18:13
Introduced a key word `__pwru_reject_all__` to inject two simple ebpf
insns when pcap filter is an L2 filter such as `arp`

Also deleted a confusing and scary warning.

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
@jschwinger233 jschwinger233 marked this pull request as ready for review September 28, 2023 03:25
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🍕

@brb brb merged commit 207ae70 into main Sep 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants