Add NaiveDateTime::checked_(add|sub)_offset
#1313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are const and public so they can be used with #1270.
Because the offset is never more than 24 hours, we can use
NaiveDate::pred_opt()
andNaiveDate::succ_opt()
Instead ofNaiveDate::add_days
. This gives a nice little performance improvement for many methods onDateTime
(benchmarks in #1069 (comment)).Most of all we can use these methods to avoid out of range panics when converting datetimes from UTC to local or back.
Split out from #1069.