fix: CCAT_CORE_USE_SECURE_PROTOCOLS #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In compose/env file, set `CCAT_CORE_USE_SECURE_PROTOCOLS=0` issue: `get_base_url()` will return `http0://...` This commit rewrites the condition in order to get the expected behavior: - `CCAT_CORE_USE_SECURE_PROTOCOLS=1 | true` will give `https://...` - everything else will give `http://...`
kodaline
force-pushed
the
fix/env_variable_secure_protocol
branch
from
4e61b80
to
cc732db
Compare
|
Thanks for adding also the tests :') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CCAT_CORE_USE_SECURE_PROTOCOLS=0get_base_url()will returnhttp0://...This commit rewrites the condition in order to get the expected behavior:
CCAT_CORE_USE_SECURE_PROTOCOLS=1 | truewill givehttps://...http://...Added more tests for
get_base_url()whenCCAT_CORE_USE_SECURE_PROTOCOLSis set to a valueType of change
Checklist: