Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholders for RateLimitBurst and RateLimitImterval added #8635

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

SanjuPal01
Copy link
Collaborator

🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@SanjuPal01 SanjuPal01 self-assigned this Oct 22, 2024
Copy link

netlify bot commented Oct 22, 2024

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 79870a7
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6718d582be95910008c4862c

Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com>
Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com>
@SanjuPal01 SanjuPal01 force-pushed the sanju/addingRateLimitPlaceholders branch from a21ec6e to 2b4b749 Compare October 22, 2024 09:24
Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com>
Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com>
Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com>
Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com>

Quality Gate failed Quality Gate failed

Failed conditions
2 New issues
13.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant