Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEF-12487 certs added to backend deployment and trimspace to prevent restart #8632

Merged
merged 10 commits into from
Oct 23, 2024

Conversation

vivekshankar1
Copy link
Collaborator

@vivekshankar1 vivekshankar1 commented Oct 16, 2024

🔩 Description: What code changed, and why?

⛓️ Related Resources

https://progresssoftware.atlassian.net/browse/CHEF-12487

packages for testing:

  • vivek-shankar/automate-ha-deployment/0.1.0/20241016112616
  • vivek-shankar/automate-cli/0.1.0/20241016114018

Demo: https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/EboMQAaIlhdMo2W5yTO_MyQBkWu4qcy7zbjVgfK4sSub3Q?e=iVYfBh

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Copy link

netlify bot commented Oct 16, 2024

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit b296df9
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/671748edae45e900086bb3f3

Signed-off-by: Vivek Shankar <vshankar@progress.com>
@vivekshankar1 vivekshankar1 changed the title Vs/certs added to backend deployment CHEF-12487 certs added to backend deployment and trimspace to prevent restart Oct 16, 2024
Signed-off-by: Vivek Shankar <vshankar@progress.com>
func (e *existingInfra) addDNTocertConfig() error {
e.log.Debug("custom certificate enabled status", e.config.Opensearch.Config.EnableCustomCerts)
if !e.config.Opensearch.Config.EnableCustomCerts {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can keep condition for pg seperately.
because any one can choose the custom cert for either of 1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>

Quality Gate failed Quality Gate failed

Failed conditions
4 New issues
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@punitmundra punitmundra merged commit 9d923a8 into main Oct 23, 2024
10 of 13 checks passed
@punitmundra punitmundra deleted the vs/certs-added-to-backend-deployment branch October 23, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants