Added the gcs plugin for external os #8107

punitmundra · 2023-08-07T05:59:05Z

🔩 Description: What code changed, and why?

Use the below package to test the changes
"punitmundra/automate-ha-cluster-ctl/0.1.0/20230825080330",
"punitmundra/automate-ha-deployment/0.1.0/20230828101150",
"punitmundra/automate-ha-opensearch/1.3.7/20230825100754",
"",

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

I have read the CONTRIBUTING document.
All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

Tests added/updated? (all new code needs new tests)
Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

netlify · 2023-08-07T05:59:13Z

👷 Deploy Preview for chef-automate processing.

Name	Link
🔨 Latest commit	`44ac645`
🔍 Latest deploy log	https://app.netlify.com/sites/chef-automate/deploys/64ec8bf772bd5500083c22ea

Signed-off-by: punitmundra <pmundra@progress.com>

components/automate-cli/cmd/chef-automate/initConfigHaTmpl.go

terraform/a2ha-terraform/modules/keystoreopensearch/templates/opensearch-keystore.sh.tpl

Signed-off-by: punitmundra <pmundra@progress.com>

sonarqube-for-infrastructure-prod · 2023-08-28T12:21:09Z

SonarQube Quality Gate

2.9% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

* bump the page Signed-off-by: punitmundra <pmundra@progress.com> * added the gcs plugin for external os Signed-off-by: punitmundra <pmundra@progress.com> * merge conflicts 3b34cae. Signed-off-by: punitmundra <pmundra@progress.com> * merge conflicts 47ab488.... Signed-off-by: punitmundra <pmundra@progress.com> * update the config-init-ha template Signed-off-by: punitmundra <pmundra@progress.com> * merge conflicts .... Signed-off-by: punitmundra <pmundra@progress.com> * rebase conflicts with cherrypick 52d40cb93 Signed-off-by: punitmundra <pmundra@progress.com> * rebase conflicts with cherrypick cd4e52469 Signed-off-by: punitmundra <pmundra@progress.com> * update the resolve comflict with cherry pick 0d15f37cf Signed-off-by: punitmundra <pmundra@progress.com> * remove the comment Signed-off-by: punitmundra <pmundra@progress.com> * terrafrom changes for gcs Signed-off-by: punitmundra <pmundra@progress.com> * merge conflicts Signed-off-by: punitmundra <pmundra@progress.com> * comment code Signed-off-by: punitmundra <pmundra@progress.com> * template fix in connector.tom Signed-off-by: punitmundra <pmundra@progress.com> * template fix in connector.tom Signed-off-by: punitmundra <pmundra@progress.com> * change the template variable to hardcode value Signed-off-by: punitmundra <pmundra@progress.com> * opensearch template change in config.toml.erb Signed-off-by: punitmundra <pmundra@progress.com> * add missing variable in input.tf Signed-off-by: punitmundra <pmundra@progress.com> * remove duplicate entry Signed-off-by: punitmundra <pmundra@progress.com> * move copy_file to exisitng resources Signed-off-by: punitmundra <pmundra@progress.com> * update the index: Signed-off-by: punitmundra <pmundra@progress.com> * remove unused variable from config.toml.erb to avoid the error Signed-off-by: punitmundra <pmundra@progress.com> * remove hardcoded changes for review Signed-off-by: punitmundra <pmundra@progress.com> * update the cli msgs Signed-off-by: punitmundra <pmundra@progress.com> * remove multiple attribute from the cli Signed-off-by: punitmundra <pmundra@progress.com> * pipeline fix Signed-off-by: punitmundra <pmundra@progress.com> * pipeline fix Signed-off-by: punitmundra <pmundra@progress.com> * dummy commit Signed-off-by: punitmundra <pmundra@progress.com> * dummy commit Signed-off-by: punitmundra <pmundra@progress.com> * dummy commit Signed-off-by: punitmundra <pmundra@progress.com> * update cli with location flag Signed-off-by: punitmundra <pmundra@progress.com> * add the example for the new field in the init-config Signed-off-by: punitmundra <pmundra@progress.com> * remove fs Signed-off-by: punitmundra <pmundra@progress.com> --------- Signed-off-by: punitmundra <pmundra@progress.com>

punitmundra requested a review from vivek-yadav August 7, 2023 05:59

punitmundra changed the title ~~Added the gcs plugin for external os~~ WIP : Added the gcs plugin for external os Aug 24, 2023

punitmundra added 13 commits August 24, 2023 15:51

bump the page

0a5dc48

Signed-off-by: punitmundra <pmundra@progress.com>

added the gcs plugin for external os

da092de

Signed-off-by: punitmundra <pmundra@progress.com>

merge conflicts 3b34cae.

548e645

Signed-off-by: punitmundra <pmundra@progress.com>

merge conflicts 47ab488....

52c892c

Signed-off-by: punitmundra <pmundra@progress.com>

update the config-init-ha template

cc8117d

Signed-off-by: punitmundra <pmundra@progress.com>

merge conflicts ....

fc7c4cf

Signed-off-by: punitmundra <pmundra@progress.com>

rebase conflicts with cherrypick 52d40cb93

489ea64

Signed-off-by: punitmundra <pmundra@progress.com>

rebase conflicts with cherrypick cd4e52469

ddb6b42

Signed-off-by: punitmundra <pmundra@progress.com>

update the resolve comflict with cherry pick 0d15f37cf

cffb423

Signed-off-by: punitmundra <pmundra@progress.com>

remove the comment

6bb06c2

Signed-off-by: punitmundra <pmundra@progress.com>

terrafrom changes for gcs

33f6aca

Signed-off-by: punitmundra <pmundra@progress.com>

merge conflicts

6cd3b5c

Signed-off-by: punitmundra <pmundra@progress.com>

comment code

fd41a0d

Signed-off-by: punitmundra <pmundra@progress.com>

punitmundra force-pushed the add-gcs-plugin-opensearch branch from 35b5fe9 to fd41a0d Compare August 25, 2023 12:32

punitmundra requested a review from a team as a code owner August 25, 2023 12:32

github-actions bot added the documentation Anything related to the Automate docs. label Aug 25, 2023

punitmundra added 10 commits August 26, 2023 14:23

template fix in connector.tom

53d16c1

Signed-off-by: punitmundra <pmundra@progress.com>

template fix in connector.tom

378b423

Signed-off-by: punitmundra <pmundra@progress.com>

change the template variable to hardcode value

b69aa42

Signed-off-by: punitmundra <pmundra@progress.com>

opensearch template change in config.toml.erb

cad522e

Signed-off-by: punitmundra <pmundra@progress.com>

add missing variable in input.tf

881c97b

Signed-off-by: punitmundra <pmundra@progress.com>

remove duplicate entry

c69bfa2

Signed-off-by: punitmundra <pmundra@progress.com>

move copy_file to exisitng resources

bc40308

Signed-off-by: punitmundra <pmundra@progress.com>

update the index:

4d70d43

Signed-off-by: punitmundra <pmundra@progress.com>

remove unused variable from config.toml.erb to avoid the error

91e236a

Signed-off-by: punitmundra <pmundra@progress.com>

remove hardcoded changes for review

8d2bee7

Signed-off-by: punitmundra <pmundra@progress.com>

punitmundra changed the title ~~WIP : Added the gcs plugin for external os~~ Added the gcs plugin for external os Aug 28, 2023

punitmundra requested a review from vivekshankar1 August 28, 2023 06:07

punitmundra added 8 commits August 28, 2023 12:12

update the cli msgs

d7c819c

Signed-off-by: punitmundra <pmundra@progress.com>

remove multiple attribute from the cli

fec1fb7

Signed-off-by: punitmundra <pmundra@progress.com>

pipeline fix

fb962eb

Signed-off-by: punitmundra <pmundra@progress.com>

pipeline fix

c315505

Signed-off-by: punitmundra <pmundra@progress.com>

dummy commit

d0c8d90

Signed-off-by: punitmundra <pmundra@progress.com>

dummy commit

d2b7594

Signed-off-by: punitmundra <pmundra@progress.com>

dummy commit

743fcfd

Signed-off-by: punitmundra <pmundra@progress.com>

update cli with location flag

2480d8d

Signed-off-by: punitmundra <pmundra@progress.com>

punitmundra requested a review from ArvinthC3000 August 28, 2023 10:29

ArvinthC3000 reviewed Aug 28, 2023

View reviewed changes

components/automate-cli/cmd/chef-automate/initConfigHaTmpl.go Show resolved Hide resolved

ArvinthC3000 reviewed Aug 28, 2023

View reviewed changes

terraform/a2ha-terraform/modules/keystoreopensearch/templates/opensearch-keystore.sh.tpl Show resolved Hide resolved

punitmundra added 2 commits August 28, 2023 16:49

add the example for the new field in the init-config

bb70051

Signed-off-by: punitmundra <pmundra@progress.com>

remove fs

44ac645

Signed-off-by: punitmundra <pmundra@progress.com>

ArvinthC3000 approved these changes Aug 28, 2023

View reviewed changes

punitmundra merged commit 0ba6a34 into main Aug 28, 2023
3 of 4 checks passed

punitmundra deleted the add-gcs-plugin-opensearch branch August 28, 2023 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added the gcs plugin for external os #8107

Added the gcs plugin for external os #8107

punitmundra commented Aug 7, 2023 •

edited

Loading

netlify bot commented Aug 7, 2023 •

edited

Loading

sonarqube-for-infrastructure-prod bot commented Aug 28, 2023

Added the gcs plugin for external os #8107

Added the gcs plugin for external os #8107

Conversation

punitmundra commented Aug 7, 2023 • edited Loading

🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

📷 Screenshots, if applicable

netlify bot commented Aug 7, 2023 • edited Loading

👷 Deploy Preview for chef-automate processing.

sonarqube-for-infrastructure-prod bot commented Aug 28, 2023

punitmundra commented Aug 7, 2023 •

edited

Loading

netlify bot commented Aug 7, 2023 •

edited

Loading