Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abdul/config fix #8099

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Abdul/config fix #8099

merged 1 commit into from
Aug 3, 2023

Conversation

iamazzeez
Copy link
Contributor

@iamazzeez iamazzeez commented Aug 1, 2023

🔩 Description: What code changed, and why?

https://chefio.atlassian.net/browse/CHEF-3837

⛓️ Related Resources

👍 Definition of Done

Added chef_server fqdn and root_ca config patch in standalone automate

👟 How to Build and Test the Change

rebuild components/automate-cli
rebuild components/automate-deployment

Try patching
Screenshot 2023-08-01 at 10 42 16 PM

it should get patched successfully

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screenshot 2023-08-01 at 10 42 16 PM

@iamazzeez iamazzeez self-assigned this Aug 1, 2023
@netlify
Copy link

netlify bot commented Aug 1, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 244af7f
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64cb333980c8c500081fdb9e

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate failed

Failed condition B Maintainability Rating on New Code (is worse than A)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@Dmaddu Dmaddu merged commit dc38c0d into main Aug 3, 2023
3 of 4 checks passed
@Dmaddu Dmaddu deleted the abdul/config_fix branch August 3, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants