Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abdul/onprem externaldb fix #8056

Closed

Conversation

iamazzeez
Copy link
Contributor

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

iamazzeez and others added 13 commits July 11, 2023 20:01
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: sandhi <sagarwal@progress.com>
Signed-off-by: sandhi <sagarwal@progress.com>
Signed-off-by: sandhi <sagarwal@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: sandhi <sagarwal@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: sandhi <sagarwal@progress.com>
Signed-off-by: sandhi <sagarwal@progress.com>
@iamazzeez iamazzeez requested a review from sandhi18 July 11, 2023 14:37
@iamazzeez iamazzeez requested a review from a team as a code owner July 11, 2023 14:37
@iamazzeez iamazzeez self-assigned this Jul 11, 2023
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Jul 11, 2023
Signed-off-by: Abdul-Az <aazeez@progress.com>
@sandhi18 sandhi18 force-pushed the sandhi/changes-in-verify-service branch from f1c4826 to f2446af Compare July 11, 2023 14:48
@iamazzeez iamazzeez closed this Jul 11, 2023
@iamazzeez iamazzeez deleted the abdul/onprem_externaldb_fix branch July 11, 2023 14:50
@sonarqube-for-infrastructure-prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants