Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix onprem determine bkp config #8053

Merged
merged 5 commits into from
Jul 11, 2023
Merged

fix onprem determine bkp config #8053

merged 5 commits into from
Jul 11, 2023

Conversation

vivekshankar1
Copy link
Collaborator

@vivekshankar1 vivekshankar1 commented Jul 11, 2023

🔩 Description: What code changed, and why?

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-3779

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

BEFORE THE CHANGE
MicrosoftTeams-image (7)

AFTER THE CHANGE
MicrosoftTeams-image (6)

Signed-off-by: Vivek Shankar <vshankar@progress.com>
@netlify
Copy link

netlify bot commented Jul 11, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 4e1f524
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64ad1fa95cc17f0008fb465f

vivekshankar1 and others added 3 commits July 11, 2023 14:21
…g.go

Co-authored-by: Arvinth C <54614142+ArvinthC3000@users.noreply.github.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
@vivek-yadav vivek-yadav merged commit 83ca75b into main Jul 11, 2023
3 checks passed
@vivek-yadav vivek-yadav deleted the fix_onprem_bkpconfig_pull branch July 11, 2023 09:33
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate failed

Failed condition B Maintainability Rating on New Code (is worse than A)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants