Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to show error if incorrect config provided for patch #8049

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

vipin230
Copy link
Collaborator

@vipin230 vipin230 commented Jul 10, 2023

🔩 Description: What code changed, and why?

Config patch command was not throwing error is incorrect provided for patch for pg and os

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-1464

👍 Definition of Done

👟 How to Build and Test the Change

  • checkout this branch CHEF-1464 and rebuild cli
  • now use this cli on any HA setup where os and pg nodes are available
  • trying patch incorrect config on pg or os nodes

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screenshot 2023-07-10 at 8 52 45 PM

Demo video

@netlify
Copy link

netlify bot commented Jul 10, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit d7f0f5e
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64ad708e832cdd0008f44db4

@vipin230 vipin230 changed the title (WIP)Changes to show error if incorrect config provided for patch Changes to show error if incorrect config provided for patch Jul 11, 2023
@vipin230 vipin230 self-assigned this Jul 11, 2023
Signed-off-by: Vipin Yadav <vipin.yadav@progress.com>
Signed-off-by: Vipin Yadav <vipin.yadav@progress.com>
@sonarqube-for-infrastructure-prod

@vivek-yadav vivek-yadav merged commit 5da2065 into main Jul 11, 2023
3 checks passed
@vivek-yadav vivek-yadav deleted the CHEF-1464 branch July 11, 2023 16:32
bvtejaswi pushed a commit that referenced this pull request Jul 17, 2023
* Changes to show error

Signed-off-by: Vipin Yadav <vipin.yadav@progress.com>

* Pr comment fix

Signed-off-by: Vipin Yadav <vipin.yadav@progress.com>

---------

Signed-off-by: Vipin Yadav <vipin.yadav@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants