Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle import type statement [sc-0] #453

Merged
merged 2 commits into from
Jan 31, 2023
Merged

fix: handle import type statement [sc-0] #453

merged 2 commits into from
Jan 31, 2023

Conversation

umutuzgur
Copy link
Member

@umutuzgur umutuzgur commented Jan 31, 2023 •
edited
Loading

I hereby confirm that I followed the code guidelines found at engineering guidelines

Notes for the reviewer

Handle the import type syntax of typescript

Closes #440

@umutuzgur umutuzgur enabled auto-merge (squash) January 31, 2023 15:48
@clample
Copy link
Collaborator

clample commented Jan 31, 2023

Nice fix!

@umutuzgur umutuzgur merged commit 827cf71 into main Jan 31, 2023
@umutuzgur umutuzgur deleted the umutuzgur/sc-0/allow-import-type branch January 31, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiroushi kiroushi kiroushi approved these changes

@clample clample clample approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error parsing TypeScript checks - baseVisitor[type] is not a function
3 participants
@umutuzgur @clample @kiroushi