Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry with search history enabled after some attempts #5370

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Oct 31, 2024

Pull Request

Closes: PRO-1762

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

In some cases egress witnessing can fail because the Solana nodes don't keep the transactions in a local cache. This isn't so bad, it just means we might retry a bit more than necessary, and also that we display the status as "pending". This should resolve it though.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (eedf6b8) to head (88dff39).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
engine/src/sol/retry_rpc.rs 0% 29 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5370    +/-   ##
======================================
- Coverage     72%     71%    -0%     
======================================
  Files        497     497            
  Lines      86352   86239   -113     
  Branches   86352   86239   -113     
======================================
- Hits       61759   61559   -200     
- Misses     21814   21893    +79     
- Partials    2779    2787     +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant