Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make boost detection more accurate #5369

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

dandanlen
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (eedf6b8) to head (b050e14).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/pallets/cf-ingress-egress/src/lib.rs 67% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5369    +/-   ##
======================================
- Coverage     72%     71%    -0%     
======================================
  Files        497     497            
  Lines      86352   86213   -139     
  Branches   86352   86213   -139     
======================================
- Hits       61759   61563   -196     
- Misses     21814   21869    +55     
- Partials    2779    2781     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dandanlen and others added 3 commits October 31, 2024 14:25
- Proof that we can report between pre and witness still rejecting a tx if the channel was not bossted
- We can not change the status of a report if its already prewitnessed
Copy link
Contributor

@Janislav Janislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dandanlen dandanlen added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 0c70f5f Oct 31, 2024
48 of 49 checks passed
@dandanlen dandanlen deleted the fix/correct-boost-detection-for-tx-reports branch October 31, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants