-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: request_swap_deposit_address_with_affiliates
refund address is consistent with destination address type
#5360
Conversation
…_address WIP: to add unit tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5360 +/- ##
======================================
- Coverage 72% 71% -0%
======================================
Files 497 497
Lines 86341 86214 -127
Branches 86341 86214 -127
======================================
- Hits 61740 61568 -172
- Misses 21821 21865 +44
- Partials 2780 2781 +1 ☔ View full report in Codecov by Sentry. |
I think the reason this is failing in the bouncer is because the SDK needs to be updated... (I can make sure this is done) |
… refactor/refund-address-type
request_swap_deposit_address_with_affiliates
refund address is consistent with destination address typerequest_swap_deposit_address_with_affiliates
refund address is consistent with destination address type
Merge queue is failing due to failed Solana CCM Swaps after runtime migration. Not sure if this is related to this PR as no migration was added. UPdate: just retried to merge and the PR went through. |
Pull Request
Closes: PRO-1709
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Make Refund parameter's address to be consistent with the destination_address