Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request_swap_deposit_address_with_affiliates refund address is consistent with destination address type #5360

Merged
merged 9 commits into from
Oct 30, 2024

Conversation

syan095
Copy link
Contributor

@syan095 syan095 commented Oct 29, 2024

Pull Request

Closes: PRO-1709

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Make Refund parameter's address to be consistent with the destination_address

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (7c403b5) to head (d4f002c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/pallets/cf-swapping/src/lib.rs 69% 2 Missing and 2 partials ⚠️
api/lib/src/lib.rs 0% 3 Missing ⚠️
state-chain/chains/src/lib.rs 89% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5360    +/-   ##
======================================
- Coverage     72%     71%    -0%     
======================================
  Files        497     497            
  Lines      86341   86214   -127     
  Branches   86341   86214   -127     
======================================
- Hits       61740   61568   -172     
- Misses     21821   21865    +44     
- Partials    2780    2781     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen
Copy link
Collaborator

dandanlen commented Oct 29, 2024

I think the reason this is failing in the bouncer is because the SDK needs to be updated...

(I can make sure this is done)

@dandanlen dandanlen changed the title refactor: request_swap_deposit_address_with_affiliates refund address is consistent with destination address type fix: request_swap_deposit_address_with_affiliates refund address is consistent with destination address type Oct 30, 2024
@dandanlen dandanlen added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@syan095 syan095 added this pull request to the merge queue Oct 30, 2024
@syan095
Copy link
Contributor Author

syan095 commented Oct 30, 2024

Merge queue is failing due to failed Solana CCM Swaps after runtime migration. Not sure if this is related to this PR as no migration was added.

UPdate: just retried to merge and the PR went through.

Merged via the queue into main with commit eedf6b8 Oct 30, 2024
48 of 49 checks passed
@syan095 syan095 deleted the refactor/refund-address-type branch October 30, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants