fix: take into account only active suspensions

[marcellorigotti]

Pull Request

Closes: PRO-xxx

Checklist

Please conduct a thorough self-review before opening the PR.

• I am confident that the code works.
• I have written sufficient tests.
• I have written and tested required migrations.
• I have updated documentation where appropriate.

Summary

Changed the way we count for suspensions, we now keep into account if the suspension is still valid, based on the current block.

[codecov]

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (5baa3dd) to head (3ac5deb).

Files with missing lines	Patch %	Lines
state-chain/runtime/src/lib.rs	8%	0 Missing and 12 partials ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##            main   #5359    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        496     496            
  Lines      86485   86361   -124     
  Branches   86485   86361   -124     
======================================
- Hits       61751   61553   -198     
- Misses     21971   22026    +55     
- Partials    2763    2782    +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dandanlen]

I think it should be > (or >=)

[dandanlen]

Suggested change

	pallet_cf_reputation::Suspensions::<Runtime>::iter().map(|(key, elem)| (key, elem.iter().filter(|(suspended_until, _)| *suspended_until < current_block).collect::<Vec<_>>().len() as u32)).collect()
	pallet_cf_reputation::Suspensions::<Runtime>::iter().map(|(key, elem)| (key, elem.iter().filter(|(suspended_until, _)| *suspended_until > current_block).count() as u32)).collect()

[marcellorigotti]

Is there a better way to filter out duplicates without collecting to a set?
I tried to use https://docs.rs/itertools/0.9.0/itertools/trait.Itertools.html#method.unique, but with no std features those method are disabled..

[msgmaxim]

Is there a better way to filter out duplicates without collecting to a set? I tried to use https://docs.rs/itertools/0.9.0/itertools/trait.Itertools.html#method.unique, but with no std features those method are disabled..

Not really, and I believe even unique from itertools uses a hashset internally.