feat: engine-runner verifies gpg signature of old dylib when downloaded #5339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylezs
force-pushed
the
feat/runner-verify-dylibs
branch
2 times, most recently
from
39e5f66
to
76b10ef
Compare
kylezs
changed the title
kylezs
force-pushed
the
feat/runner-verify-dylibs
branch
from
76b10ef
to
83c27bd
Compare
kylezs
force-pushed
the
feat/runner-verify-dylibs
branch
from
83c27bd
to
24a1c9a
Compare
ahasna
approved these changes
Oct 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5339 +/- ##
======================================
- Coverage 71% 71% -0%
======================================
Files 491 494 +3
Lines 85327 85672 +345
Branches 85327 85672 +345
======================================
+ Hits 60776 60976 +200
- Misses 21839 21934 +95
- Partials 2712 2762 +50 ☔ View full report in Codecov by Sentry. |
martin-chainflip
approved these changes
Oct 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Rerunning, was just manually uploaded artifacts were missing the old dylib (this is automated after 1.7) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
syan095
added a commit
that referenced
this pull request
Oct 29, 2024
…waps-close-accounts * origin/main: (44 commits) fix: expire all previous epochs (#5279) feat: add/update contract swaps parameters (#5343) chore: add address to solana logging (#5353) fix: ignore dust underflows in order fills rpc (#5352) chore: consistent naming prewitnessed (#5351) feat: engine-runner verifies gpg signature of old dylib when downloaded (#5339) feat: tainted transaction reporting (#5310) bug: change_utxo not always present (#5340) feat: structured error return types for rpcs (#5346) chore: unify dependencies to root cargo.toml (#5333) feat: Submit a slot number alongside nonce (#5297) chore: use node version from `.nvmrc` 📌 (#5336) chore: add engine account_info logging (#5347) chore: replace manual scale encoding for ts-scale (#5335) chore: more consistent params in Broker API (#5342) feat: broker can encode btc smart contract call (#5329) chore: localnet recreate script can use defaults (#5338) feat: witnessing btc smart contract swaps (#5331) feat: Solana CCM fallback (#5316) fix: scale types for pending ceremonies (#5286) ... # Conflicts: # Cargo.lock # state-chain/chains/src/sol/api.rs # state-chain/pallets/cf-broadcast/src/migrations.rs # state-chain/pallets/cf-environment/Cargo.toml
dandanlen
pushed a commit
that referenced
this pull request
Oct 30, 2024
…ed (#5339) * feat: runner verifies downloaded dylibs * chore: consistent CI param naming * chore: clippy * fix: LP account already setup in 1.6.8 * chore: eslint
dandanlen
pushed a commit
that referenced
this pull request
Oct 30, 2024
…ed (#5339) * feat: runner verifies downloaded dylibs * chore: consistent CI param naming * chore: clippy * fix: LP account already setup in 1.6.8 * chore: eslint
dandanlen
pushed a commit
that referenced
this pull request
Oct 31, 2024
…ed (#5339) * feat: runner verifies downloaded dylibs * chore: consistent CI param naming * chore: clippy * fix: LP account already setup in 1.6.8 * chore: eslint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1622
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
When the is_mainnet flag is
trueon the build job, the engine-runner will now download from the pgks.chainflip.io - which contain only the binaries built for mainnet. It will also verify the signature of these dylibs to ensure that the chainflip releaser has released them.