fix: keyholder check should use HistoricalActiveEpochs
#5325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more reliable than using HistoricalAuthorities because the latter is not cleared when an epoch expires. Preivously is was possible for a validator to be considered active for an expired epoch if the epochs were expired out-of-order (see updated test case).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5325 +/- ##
======================================
- Coverage 71% 71% -0%
======================================
Files 488 488
Lines 84898 84766 -132
Branches 84898 84766 -132
======================================
- Hits 60376 60191 -185
- Misses 21822 21874 +52
- Partials 2700 2701 +1 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
syan095
added a commit
that referenced
this pull request
Oct 14, 2024
…lana-ccm * origin/main: ci: upgrade action version to supress deprecation warnings ⚙️ (#5330) feat: handle rotation tx construction failures (#5307) test(bouncer): add test for new utility (#5324) fix: keyholder check should use `HistoricalActiveEpochs` (#5325) feat: BTC contract swap encoding (#5311)
dandanlen
added a commit
that referenced
this pull request
Oct 30, 2024
This is more reliable than using HistoricalAuthorities because the latter is not cleared when an epoch expires. Preivously is was possible for a validator to be considered active for an expired epoch if the epochs were expired out-of-order (see updated test case).
dandanlen
added a commit
that referenced
this pull request
Oct 31, 2024
This is more reliable than using HistoricalAuthorities because the latter is not cleared when an epoch expires. Preivously is was possible for a validator to be considered active for an expired epoch if the epochs were expired out-of-order (see updated test case).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1721
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
This is more reliable than using HistoricalAuthorities because the latter is not cleared when an epoch expires.
Preivously is was possible for a validator to be considered active for an expired epoch if the epochs were expired out-of-order (see updated test case).