fix: ignore dust underflows in order fills rpc (#5352)

fix: ignore dust underflow
chainflip-io · Oct 31, 2024 · dfe55cd · dfe55cd
1 parent f0c44b4
commit dfe55cd
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/state-chain/custom-rpc/src/order_fills.rs b/state-chain/custom-rpc/src/order_fills.rs
@@ -66,7 +66,17 @@ fn order_fills_for_pool<'a>(
 						if let Some((previous_collected, _)) = option_previous_order_state {
 							(
 								collected.fees - previous_collected.fees,
-								collected.sold_amount - previous_collected.sold_amount,
+								collected
+									.sold_amount
+									.checked_sub(previous_collected.sold_amount)
+									.unwrap_or_else(|| {
+										log::info!(
+															"Ignored dust sold_amount underflow. Current: {}, Previous: {}",
+															collected.sold_amount,
+															previous_collected.sold_amount
+														);
+										0.into()
+									}),
 								collected.bought_amount - previous_collected.bought_amount,
 							)
 						} else {