Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver: use ExAllocatePool2 #340

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

makinbacon21
Copy link

ExAllocatePoolWithTag is deprecated as of Win10 20.04
This adds compat for newer WDK releases
I'll admit this was a oneshot PR, so def needs review, but this should mostly be a drop-in replacement (https://learn.microsoft.com/en-us/windows-hardware/drivers/kernel/updating-deprecated-exallocatepool-calls)

ExAllocatePoolWithTag is deprecated as of Win10 20.04
@vadimgrn
Copy link

vadimgrn commented Jan 22, 2023

I recommend turning your attention to https://github.com/vadimgrn/usbip-win2 because this repository is de facto abandoned.

@makinbacon21
Copy link
Author

there is no arm64 support in your fork, and the dev branch here does not seem abandoned, just the dev makes bulk commits he force pushes

@vadimgrn
Copy link

Let's see, the last commit was Jan 16 2022. It's better to add required architecture than to do work that was already done.

@makinbacon21
Copy link
Author

no need to be rude--if you'd like to add arm64 support to your fork, be my guest. for now, i will use what is available, which is this. grep-ing and replacing one method with another requires far less effort compared to adding full arm64 support to another fork.

@makinbacon21
Copy link
Author

i do not care, i did 5 mins of work to help myself, and dropped this in here as i always do with oss projects, so the maintainer can see if they would like to. i don't care if it's upstreamed or not, but there it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants