Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for 1.12.1, 1.12.2 and 1.12.3 #1264

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

inteon
Copy link
Member

@inteon inteon commented Jul 26, 2023

These release notes were missing.
Based on https://github.com/cert-manager/cert-manager/releases

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jul 26, 2023
@inteon inteon requested a review from maelvls July 26, 2023 13:24
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 26, 2023
@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit d47abc4
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/64c79e83ca1a220007b0b3ff
😎 Deploy Preview https://deploy-preview-1264--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the change log.

/lgtm

nit: the latest released version should come on top since that's what people should be looking at when they arrive on the 1.12 page: they should be aware of what the earliest version on the 1.12 branch is. This is what Kubernetes does: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.27.md

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@maelvls
Copy link
Member

maelvls commented Aug 1, 2023

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@jetstack-bot jetstack-bot merged commit da08e38 into cert-manager:master Aug 1, 2023
1 check passed
@inteon inteon deleted the 1.12-patch-release-notes branch August 2, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants