Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Further clarify R4 Encounter sorting details #398

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Further clarify R4 Encounter sorting details #398

wants to merge 2 commits into from

Conversation

FFSol
Copy link
Contributor

@FFSol FFSol commented Jun 18, 2020 •
edited
Loading

Description

Addressing slightly ambiguous verbiage in #381

PR Checklist

  • Screenshot(s) of changes attached before changes merged.
  • Screenshot(s) of changes attached after changes merged and published.

@FFSol FFSol requested review from beichhor and daliboz June 18, 2020 15:58
@FFSol
Copy link
Contributor Author

FFSol commented Jun 18, 2020

Screen Shot 2020-06-18 at 11 03 32 AM

@beichhor
Copy link
Contributor

I don't think this wording really makes it clearer. We need to state that the Encounters returned per page will be more recent than Encounters on subsequent pages. We need to also be clear that within a page the sorting is not guaranteed.

daliboz
daliboz suggested changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@daliboz daliboz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as Ben - we need to clarify. Encounter responses will be sorted from newest to oldest page by Encounter.period, though items within a single page may not be sorted.

@daliboz daliboz changed the base branch from master to main July 14, 2020 18:24
@FFSol
Copy link
Contributor Author

FFSol commented Jul 23, 2020

Updated screenshot:
Screen Shot 2020-07-23 at 10 57 40 AM

MaxPhilips
MaxPhilips approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@MaxPhilips MaxPhilips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if we ditch the second period at the end

@amcginn amcginn added the R4 Applies to R4 FHIR resources label Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daliboz daliboz daliboz requested changes

@MaxPhilips MaxPhilips MaxPhilips approved these changes

@beichhor beichhor beichhor approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
R4 Applies to R4 FHIR resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FFSol @beichhor @daliboz @MaxPhilips @amcginn