Add slider values & fix overflow errors #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzLamm
commented
Mar 18, 2024
| normalized_values = (point_values - point_values.min()) / ( | ||
| point_values.max() - point_values.min() | ||
| point_values.max() - point_values.min() + np.finfo(float).eps |
There was a problem hiding this comment.
This line was causing problems with the integer overflow. After converting tomograms to float, it should not be the case anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds values of the current depth of the slider to the interface (see attached screenshot). This was requested from people in our lab -- it is important to know how "far away" from the membrane the current projection actually is.
I also encountered several overflow issues, as also mentioned here: #22
This was due to the tomogram consisting of signed integer values and then substracting the minimum value during normalization (see highlighted code). I converted tomograms to float when loading them to fix this.