Use Root scope when current is null (fixes #646) #670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #646 by using Root scope when current scope in
ExtensionContainerScopeCache.current
isnull
. This can happen whenWindsorScopedServiceProvider
is called from a new thread (or rather different async context).In this situation
ForcedScope
uses the original root scope. It also restores it asExtensionContainerScopeCache.current
on dispose.The only case that I haven't figured out is when resolving directly via
IWindsorContainer
(and not throughIServiceProvider
) on a new thread.ExtensionContainerScopeAccessor.GetScope
still throws "No scope available"