29 implement docusign webhook listener #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to responded, recipient authentication failure, and recipient delegate
|
@KevinHa48 @Yun-L Currently this api route takes in a key as query param. If that key matches our environment variable key, then the route will be authenticated. Otherwise, it'll return http 403. Is this secure? I'm not sure how to feel about it but I'm also not sure what would be better. |
nevermind. Docusign has their own integration for keys like this:
I'll make a separate issue for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
/docusign/webhookroute for the docusign webhook.This MR does not implement the logic for every single webhook. This MR simply sets up the skeleton for handling webhooks. The implementation cannot continue past this point until #19 gets resolved.
Another note I want to add is that this issue is currently difficult to test. Once this gets merged, We should work on having some kind of developer environment on EC2 for this so we can test with real docusign events.