add installation instructions page #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for workshop-template-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I think this is a good start! It's definitely better than the other solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in swcarpentry/shell-novice#1417 (comment), this adds a new page containing the installation instructions for all tools and nothing else.
Unfortunately there does not seem to be a way to directly obtain an array of the filenames inside
_includes, so I have had to compromise with an array defined in the page metadata. I added a comment to document this, providing instructions for anyone who needs to add a new block of instructions in the future.If and when this is merged, I will open PRs to adjust link targets on lesson Setup pages, so that they point to this page instead of the bottom of the workshop-template landing page (with all of its various and confusing FIXME text).