Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision session 1.1 and 1.2 #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KyriJanssen
Copy link
Collaborator

Added slides part 1.1
Revisions rmd files session 1.1 and 1.2

Added slides part 1.1
Revisions rmd files session 1.1 and 1.2
Copy link

github-actions bot commented May 7, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/r-geospatial-urban/compare/md-outputs..md-outputs-PR-47

The following changes were observed in the rendered markdown documents:

 01-intro-to-r.md                    |  14 +-
 02-data-structures.md               |  93 ++++-
 1-Intro-to-R-slides.html (new)      | 794 ++++++++++++++++++++++++++++++++++++
 18-import-and-visualise-osm-data.md |   4 +-
 md5sum.txt                          |   4 +-
 5 files changed, 870 insertions(+), 39 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-05-07 09:59:52 +0000

github-actions bot pushed a commit that referenced this pull request May 7, 2024
Copy link
Collaborator

@cforgaci cforgaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KyriJanssen! I left some comments and suggestions.

@@ -317,6 +304,7 @@ download.file(
)

```
The data we just downloaded is data about country statistics, containing information on, for instance, GDP and life-expectancy. We will work with this data later this morning
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I would remove references to dayparts (e.g., "this morning") as the lesson should fit any other set-up (e.g., run in four afternoons) when run by others.

:::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: callout

### Escaping

The console shows it's ready to get new commands with `>` sign.
It will show `+` sign if it still requires input for the command to be executed.

Sometimes you don't know what is missing/ you change your mind and
want to run something else, or your code is running much too long
and you just want it to stop.
The way to do it is to press <kbd>Esc</kbd>.

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this callout deleted entirely? What's the reason?

Comment on lines +67 to +69
You can also inspect vectors with `str()` function. In factor vectors,
it shows the underlying values of each category.
You can also see the structure in the environment tab of RStudio.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can also inspect vectors with `str()` function. In factor vectors,
it shows the underlying values of each category.
You can also see the structure in the environment tab of RStudio.
You can also inspect vectors with the `str()` function. In factor vectors,
it shows the underlying values of each category.
The structure of an object can also be examined in the Environment tab of RStudio.

@@ -139,7 +147,13 @@ is.na(with_na) # This will produce a vector of logical values,
# stating if a statement 'This element of the vector is a missing value'
# is true or not

#in order to see how many values are missing in our with_na vector, we can use the sum function
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#in order to see how many values are missing in our with_na vector, we can use the sum function
# to see how many values are missing in our with_na vector, we can use the sum function

Comment on lines +25 to +27
So far we've looked on individual values, such as x <- 100. Now we will move to a data structure
called vectors. Vectors are arrays of values of the same data type. So now we combine multiple values into one object:
x <- c(100, 200)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
So far we've looked on individual values, such as x <- 100. Now we will move to a data structure
called vectors. Vectors are arrays of values of the same data type. So now we combine multiple values into one object:
x <- c(100, 200)
So far we've looked at individual values, such as x <- 100. Now we will move to a data structure
called vectors. Vectors are arrays of values of the same data type. So now we combine multiple values into one object:
x <- c(100, 200)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants