Restrict removing from a 2 node ceph cluster #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
masnax
force-pushed
the
remove-restriction
branch
from
b4add88
to
45b1df7
Compare
Without this, the remaining cluster may not function properly when creating instances/volumes. Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
roosterfish
requested changes
Oct 21, 2024
masnax
force-pushed
the
remove-restriction
branch
from
c897d66
to
80bbc23
Compare
roosterfish
requested changes
Oct 22, 2024
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Instead of using `|| false`, these checks were all using `|| true` and as such expected errors were silently passing without any error. Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
… installed services Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
masnax
force-pushed
the
remove-restriction
branch
from
99abe3d
to
54c51af
Compare
roosterfish
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MicroCeph does not clean up the monmap on cluster removal below 3 nodes, so if we have a 2-node cluster and we remove a node which is still in the monmap, the remaining node will become unresponsive until the monmap is manually repaired.
In our case, it makes more sense to just inform the user to do this before it gets to a point where their ceph cluster is broken.