-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict removing from a 2 node ceph cluster #439
Conversation
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
b4add88
to
45b1df7
Compare
Without this, the remaining cluster may not function properly when creating instances/volumes. Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good only a few smaller comments.
Also nice find with the replication factor resize when scaling down.
c897d66
to
80bbc23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry haven't seen it in the last review, only one more comment in regards to the external link.
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Instead of using `|| false`, these checks were all using `|| true` and as such expected errors were silently passing without any error. Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
… installed services Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
99abe3d
to
54c51af
Compare
MicroCeph does not clean up the monmap on cluster removal below 3 nodes, so if we have a 2-node cluster and we remove a node which is still in the monmap, the remaining node will become unresponsive until the monmap is manually repaired.
In our case, it makes more sense to just inform the user to do this before it gets to a point where their ceph cluster is broken.