github: add system tests #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
force-pushed
the
system-tests
branch
25 times, most recently
from
f1d0e01
to
a07d57f
Compare
simondeziel
force-pushed
the
system-tests
branch
4 times, most recently
from
21b94f8
to
b53818d
Compare
simondeziel
force-pushed
the
system-tests
branch
2 times, most recently
from
55538fb
to
1f2b2e7
Compare
…#426) Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
We don't want to match on any digit present anywhere like that: ``` $ echo "disk2" | grep -P '\d+' 2 ``` Instead, require the searched string to be made of digits only. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
force-pushed
the
system-tests
branch
from
1f2b2e7
to
c5970e0
Compare
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
force-pushed
the
system-tests
branch
from
c5970e0
to
a827156
Compare
simondeziel
requested review from
tomponline,
masnax,
roosterfish and
markylaing
as code owners
tomponline
reviewed
Apr 19, 2024
tomponline
reviewed
Apr 19, 2024
tomponline
reviewed
Apr 19, 2024
| @@ -959,9 +959,9 @@ setup_system() { | |||
|
|
|||
| if [ -n "${MICROCLOUD_SNAP_PATH}" ]; then | |||
| lxc file push "${MICROCLOUD_SNAP_PATH}" "${name}"/root/microcloud.snap | |||
| lxc exec "${name}" -- sh -c "PATH=\$PATH:/snap/bin snap install --devmode /root/microcloud.snap" | |||
| lxc exec "${name}" -- snap install --devmode /root/microcloud.snap | |||
There was a problem hiding this comment.
We should be using --dangerous rather than --devmode as the latter isn't confined and isn't a representative test.
tomponline
reviewed
Apr 19, 2024
tomponline
reviewed
Apr 19, 2024
tomponline
reviewed
Apr 19, 2024
tomponline
reviewed
Apr 19, 2024
tomponline
reviewed
Apr 19, 2024
tomponline
approved these changes
Apr 19, 2024
roosterfish
reviewed
Apr 19, 2024
|
All the feedback is being addressed in #290 (still in draft). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.