Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap: wait for daemon #443

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

sabaini
Copy link
Collaborator

@sabaini sabaini commented Oct 16, 2024

Description

Wait for microcephd readiness before attempting to bootstrap. Depending on machine load this can occasionally lead to a race otherwise

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CleanCode (Code refactor, test updates, does not introduce functional changes)
  • Documentation update (Doc only change)

How Has This Been Tested?

NOTE: All functional changes should accompany corresponding tests (unit tests, functional tests etc).

Please describe the addition/modification of tests done to verify this change. Please also list any relevant details for your test configuration.

Contributor's Checklist

Please check that you have:

  • self-reviewed the code in this PR.
  • added code comments, particularly in hard-to-understand areas.
  • updated the user documentation with corresponding changes.
  • added tests to verify effectiveness of this change.

Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
Copy link
Contributor

@UtkarshBhatthere UtkarshBhatthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@UtkarshBhatthere
Copy link
Contributor

I can't seem to find the associated bug for this fix. Please add it if we have any tracker.

@sabaini
Copy link
Collaborator Author

sabaini commented Oct 17, 2024

This was reported internally (thanks @roosterfish for the hint!)

@sabaini sabaini merged commit 91a9d97 into canonical:main Oct 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants